[v0.3.2] 版本更新

- [A] 对于UPDATE类型的SQL操作采用 try-with-resources 形式获取链接与statement，避免中途报错而导致相关流未关闭。
- [U] 声明 setKeyIndex(int) 过时并移除 defaultKeyIndex() 方法，改为更明确的 setReturnGeneratedKeys(boolean) 与 returnGeneratedKeys() 方法，避免填入错误的index。

easysql-impl/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <artifactId>easysql-parent</artifactId>
         <groupId>cc.carm.lib</groupId>
-        <version>0.3.1</version>
+        <version>0.3.2</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

easysql-impl/src/main/java/cc/carm/lib/easysql/action/PreparedSQLBatchUpdateActionImpl.java

@@ -15,63 +15,60 @@ import java.util.List;
 import java.util.stream.Collectors;
 
 public class PreparedSQLBatchUpdateActionImpl
-        extends AbstractSQLAction<List<Integer>>
-        implements PreparedSQLUpdateBatchAction {
+		extends AbstractSQLAction<List<Integer>>
+		implements PreparedSQLUpdateBatchAction {
 
-    int keyIndex = -1;
-    List<Object[]> allParams;
+	boolean returnKeys = false;
+	List<Object[]> allParams;
 
-    public PreparedSQLBatchUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql) {
-        super(manager, sql);
-        this.allParams = new ArrayList<>();
-    }
+	public PreparedSQLBatchUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql) {
+		super(manager, sql);
+		this.allParams = new ArrayList<>();
+	}
 
-    @Override
-    public PreparedSQLUpdateBatchAction setAllParams(Iterable<Object[]> allParams) {
-        List<Object[]> paramsList = new ArrayList<>();
-        allParams.forEach(paramsList::add);
-        this.allParams = paramsList;
-        return this;
-    }
+	@Override
+	public PreparedSQLUpdateBatchAction setAllParams(Iterable<Object[]> allParams) {
+		List<Object[]> paramsList = new ArrayList<>();
+		allParams.forEach(paramsList::add);
+		this.allParams = paramsList;
+		return this;
+	}
 
-    @Override
-    public PreparedSQLUpdateBatchAction addParamsBatch(Object... params) {
-        this.allParams.add(params);
-        return this;
-    }
+	@Override
+	public PreparedSQLUpdateBatchAction addParamsBatch(Object... params) {
+		this.allParams.add(params);
+		return this;
+	}
 
-    @Override
-    public PreparedSQLUpdateBatchAction setKeyIndex(int keyColumnIndex) {
-        this.keyIndex = keyColumnIndex;
-        return this;
-    }
+	@Override
+	public PreparedSQLUpdateBatchAction setReturnGeneratedKeys(boolean returnGeneratedKey) {
+		this.returnKeys = returnGeneratedKey;
+		return this;
+	}
 
-    @Override
-    public @NotNull List<Integer> execute() throws SQLException {
-        List<Integer> returnedValues;
-        Connection connection = getManager().getConnection();
-        PreparedStatement statement = StatementUtil.createPrepareStatementBatch(
-                connection, getSQLContent(), allParams, keyIndex > 0
-        );
-        outputDebugMessage();
-        if (keyIndex > 0) {
-            statement.executeBatch();
-            List<Integer> generatedKeys = new ArrayList<>();
-            ResultSet resultSet = statement.getGeneratedKeys();
-            if (resultSet != null) {
-                while (resultSet.next()) generatedKeys.add(resultSet.getInt(keyIndex));
-                resultSet.close();
-            }
-            returnedValues = generatedKeys;
-        } else {
-            int[] executed = statement.executeBatch();
-            returnedValues = Arrays.stream(executed).boxed().collect(Collectors.toList());
-        }
+	@Override
+	public @NotNull List<Integer> execute() throws SQLException {
+		try (Connection connection = getManager().getConnection()) {
+			try (PreparedStatement statement = StatementUtil.createPrepareStatementBatch(
+					connection, getSQLContent(), allParams, returnKeys
+			)) {
 
-        statement.close();
-        connection.close();
+				outputDebugMessage();
+				int[] executed = statement.executeBatch();
 
-        return returnedValues;
-    }
+				if (!returnKeys) return Arrays.stream(executed).boxed().collect(Collectors.toList());
+				else {
+					try (ResultSet resultSet = statement.getGeneratedKeys()) {
+						List<Integer> generatedKeys = new ArrayList<>();
+						while (resultSet.next()) {
+							generatedKeys.add(resultSet.getInt(1));
+						}
+						return generatedKeys;
+					}
+				}
+			}
+
+		}
+	}
 
 }

easysql-impl/src/main/java/cc/carm/lib/easysql/action/PreparedSQLUpdateActionImpl.java

@@ -24,12 +24,12 @@ public class PreparedSQLUpdateActionImpl
 	}
 
 	public PreparedSQLUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql,
-									   @Nullable List<Object> params) {
+	                                   @Nullable List<Object> params) {
 		this(manager, sql, params == null ? null : params.toArray());
 	}
 
 	public PreparedSQLUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql,
-									   @Nullable Object[] params) {
+	                                   @Nullable Object[] params) {
 		super(manager, sql);
 		this.params = params;
 	}
@@ -53,28 +53,25 @@ public class PreparedSQLUpdateActionImpl
 
 	@Override
 	public @NotNull Integer execute() throws SQLException {
-		int value = -1;
+		try (Connection connection = getManager().getConnection()) {
+
+			try (PreparedStatement statement = StatementUtil.createPrepareStatement(
+					connection, getSQLContent(), params, returnGeneratedKeys
+			)) {
+
+				outputDebugMessage();
+
+				int changes = statement.executeUpdate();
+				if (!returnGeneratedKeys) return changes;
+				else {
+					try (ResultSet resultSet = statement.getGeneratedKeys()) {
+						return resultSet.next() ? resultSet.getInt(1) : -1;
+					}
+				}
 
-		Connection connection = getManager().getConnection();
-		PreparedStatement statement = StatementUtil.createPrepareStatement(
-				connection, getSQLContent(), params, keyIndex > 0
-		);
-		outputDebugMessage();
-		if (keyIndex > 0) {
-			statement.executeUpdate();
-			ResultSet resultSet = statement.getGeneratedKeys();
-			if (resultSet != null) {
-				if (resultSet.next()) value = resultSet.getInt(keyIndex);
-				resultSet.close();
 			}
-		} else {
-			value = statement.executeUpdate();
 		}
 
-		statement.close();
-		connection.close();
-
-		return value;
 	}
 
 }

easysql-impl/src/main/java/cc/carm/lib/easysql/action/SQLUpdateActionImpl.java

@@ -13,42 +13,36 @@ public class SQLUpdateActionImpl
 		extends AbstractSQLAction<Integer>
 		implements SQLUpdateAction {
 
-    int keyIndex = -1;
+	boolean returnGeneratedKeys = false;
 
-    public SQLUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql) {
-        super(manager, sql);
-    }
+	public SQLUpdateActionImpl(@NotNull SQLManagerImpl manager, @NotNull String sql) {
+		super(manager, sql);
+	}
 
-    @Override
-    public @NotNull Integer execute() throws SQLException {
-        int returnedValue = -1;
-        Connection connection = getManager().getConnection();
-        Statement statement = connection.createStatement();
-        outputDebugMessage();
-        if (keyIndex > 0) {
-            statement.executeUpdate(getSQLContent(), Statement.RETURN_GENERATED_KEYS);
-            ResultSet resultSet = statement.getGeneratedKeys();
-            if (resultSet != null) {
-                if (resultSet.next()) {
-                    returnedValue = resultSet.getInt(keyIndex);
-                }
-                resultSet.close();
-            }
-        } else {
-            returnedValue = statement.executeUpdate(getSQLContent());
-        }
+	@Override
+	public @NotNull Integer execute() throws SQLException {
+		try (Connection connection = getManager().getConnection()) {
+			try (Statement statement = connection.createStatement()) {
+				outputDebugMessage();
 
-        statement.close();
-        connection.close();
+				if (!returnGeneratedKeys) {
+					return statement.executeUpdate(getSQLContent());
+				} else {
+					statement.executeUpdate(getSQLContent(), Statement.RETURN_GENERATED_KEYS);
 
-        return returnedValue;
-    }
+					try (ResultSet resultSet = statement.getGeneratedKeys()) {
+						return resultSet.next() ? resultSet.getInt(1) : -1;
+					}
+				}
+			}
+		}
+	}
 
 
-    @Override
-    public SQLUpdateActionImpl setKeyIndex(int keyIndex) {
-        this.keyIndex = keyIndex;
-        return this;
-    }
+	@Override
+	public SQLUpdateAction setReturnGeneratedKey(boolean returnGeneratedKey) {
+		this.returnGeneratedKeys = returnGeneratedKey;
+		return this;
+	}
 
 }

easysql-impl/src/main/java/cc/carm/lib/easysql/action/SQLUpdateBatchActionImpl.java

@@ -36,20 +36,21 @@ public class SQLUpdateBatchActionImpl
 
 	@Override
 	public @NotNull List<Integer> execute() throws SQLException {
-		Connection connection = getManager().getConnection();
-		Statement statement = connection.createStatement();
-		outputDebugMessage();
+		try (Connection connection = getManager().getConnection()) {
+
+			try (Statement statement = connection.createStatement()) {
+				outputDebugMessage();
+
+				for (String content : this.sqlContents) {
+					statement.addBatch(content);
+				}
+
+				int[] executed = statement.executeBatch();
+
+				return Arrays.stream(executed).boxed().collect(Collectors.toList());
+			}
 
-		for (String content : this.sqlContents) {
-			statement.addBatch(content);
 		}
-		int[] executed = statement.executeBatch();
-		List<Integer> returnedValues = Arrays.stream(executed).boxed().collect(Collectors.toList());
-
-		statement.close();
-		connection.close();
-
-		return returnedValues;
 	}
 
 	@Override

easysql-impl/src/main/java/cc/carm/lib/easysql/action/query/PreparedQueryActionImpl.java

@@ -9,7 +9,6 @@ import org.jetbrains.annotations.Nullable;
 
 import java.sql.Connection;
 import java.sql.PreparedStatement;
-import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
@@ -54,21 +53,34 @@ public class PreparedQueryActionImpl extends QueryActionImpl implements Prepared
 
 		Connection connection = getManager().getConnection();
 		PreparedStatement preparedStatement;
-		if (handler == null) {
-			preparedStatement = StatementUtil.createPrepareStatement(connection, getSQLContent(), this.params);
-		} else {
-			preparedStatement = connection.prepareStatement(getSQLContent());
-			handler.accept(preparedStatement);
+		try {
+			if (handler == null) {
+				preparedStatement = StatementUtil.createPrepareStatement(connection, getSQLContent(), this.params);
+			} else {
+				preparedStatement = connection.prepareStatement(getSQLContent());
+				handler.accept(preparedStatement);
+			}
+		} catch (SQLException exception) {
+			connection.close();
+			throw exception;
 		}
 
-		long executeTime = System.currentTimeMillis();
-		ResultSet resultSet = preparedStatement.executeQuery();
+		try {
+			long executeTime = System.currentTimeMillis();
+			SQLQueryImpl query = new SQLQueryImpl(
+					getManager(), this,
+					connection, preparedStatement,
+					preparedStatement.executeQuery(),
+					executeTime
+			);
+			getManager().getActiveQuery().put(getActionUUID(), query);
 
-		return new SQLQueryImpl(
-				getManager(), this,
-				connection, preparedStatement, resultSet,
-				executeTime
-		);
+			return query;
+		} catch (SQLException exception) {
+			preparedStatement.close();
+			connection.close();
+			throw exception;
+		}
 
 	}
 }

easysql-impl/src/main/java/cc/carm/lib/easysql/action/query/QueryActionImpl.java

@@ -10,7 +10,6 @@ import cc.carm.lib.easysql.query.SQLQueryImpl;
 import org.jetbrains.annotations.NotNull;
 
 import java.sql.Connection;
-import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
 
@@ -24,21 +23,32 @@ public class QueryActionImpl extends AbstractSQLAction<SQLQuery> implements Quer
 	public @NotNull SQLQueryImpl execute() throws SQLException {
 
 		Connection connection = getManager().getConnection();
-		Statement statement = connection.createStatement();
+		Statement statement;
 
+		try {
+			statement = connection.createStatement();
+		} catch (SQLException ex) {
+			connection.close();
+			throw ex;
+		}
+		
 		outputDebugMessage();
+		try {
+			long executeTime = System.currentTimeMillis();
+			SQLQueryImpl query = new SQLQueryImpl(
+					getManager(), this,
+					connection, statement,
+					statement.executeQuery(getSQLContent()),
+					executeTime
+			);
+			getManager().getActiveQuery().put(getActionUUID(), query);
 
-		long executeTime = System.currentTimeMillis();
-		ResultSet resultSet = statement.executeQuery(getSQLContent());
-		SQLQueryImpl query = new SQLQueryImpl(
-				getManager(), this,
-				connection, statement, resultSet,
-				executeTime
-		);
-
-		getManager().getActiveQuery().put(getActionUUID(), query);
-
-		return query;
+			return query;
+		} catch (SQLException exception) {
+			statement.close();
+			connection.close();
+			throw exception;
+		}
 	}
 
 

easysql-impl/src/main/java/cc/carm/lib/easysql/builder/impl/TableQueryBuilderImpl.java

@@ -8,80 +8,81 @@ import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 public class TableQueryBuilderImpl
-        extends AbstractConditionalBuilder<TableQueryBuilder, PreparedQueryAction>
-        implements TableQueryBuilder {
+		extends AbstractConditionalBuilder<TableQueryBuilder, PreparedQueryAction>
+		implements TableQueryBuilder {
 
-    @NotNull String tableName;
+	@NotNull String tableName;
 
-    String[] columns;
+	String[] columns;
 
-    @Nullable String orderBy;
+	@Nullable String orderBy;
 
-    int[] pageLimit;
+	int[] pageLimit;
 
-    public TableQueryBuilderImpl(@NotNull SQLManagerImpl manager, @NotNull String tableName) {
-        super(manager);
-        this.tableName = tableName;
-    }
+	public TableQueryBuilderImpl(@NotNull SQLManagerImpl manager, @NotNull String tableName) {
+		super(manager);
+		this.tableName = tableName;
+	}
 
-    @Override
-    public PreparedQueryActionImpl build() {
-        StringBuilder sqlBuilder = new StringBuilder();
-        sqlBuilder.append("SELECT").append(" ");
-        if (columns == null || columns.length < 1) {
-            sqlBuilder.append("*");
-        } else {
-            for (int i = 0; i < columns.length; i++) {
-                String name = columns[i];
-                sqlBuilder.append("`").append(name).append("`");
-                if (i != columns.length - 1) {
-                    sqlBuilder.append(",");
-                }
-            }
-        }
+	@Override
+	public PreparedQueryActionImpl build() {
+		StringBuilder sqlBuilder = new StringBuilder();
+		sqlBuilder.append("SELECT").append(" ");
+		if (columns == null || columns.length < 1) {
+			sqlBuilder.append("*");
+		} else {
+			for (int i = 0; i < columns.length; i++) {
+				String name = columns[i];
+				sqlBuilder.append("`").append(name).append("`");
+				if (i != columns.length - 1) {
+					sqlBuilder.append(",");
+				}
+			}
+		}
 
-        sqlBuilder.append(" ").append("FROM").append(" ");
-        sqlBuilder.append("`").append(tableName).append("`");
+		sqlBuilder.append(" ").append("FROM").append(" ");
+		sqlBuilder.append("`").append(tableName).append("`");
 
-        if (hasConditions()) sqlBuilder.append(" ").append(buildConditionSQL());
+		if (hasConditions()) sqlBuilder.append(" ").append(buildConditionSQL());
 
-        if (pageLimit != null && pageLimit.length == 2) {
-            sqlBuilder.append(" LIMIT ").append(pageLimit[0]).append(",").append(pageLimit[1]);
-        } else if (limit > 0) {
-            sqlBuilder.append(" ").append(buildLimitSQL());
-        }
+		if (orderBy != null) sqlBuilder.append(" ").append(orderBy);
 
-        if (orderBy != null) sqlBuilder.append(orderBy);
+		if (pageLimit != null && pageLimit.length == 2) {
+			sqlBuilder.append(" LIMIT ").append(pageLimit[0]).append(",").append(pageLimit[1]);
+		} else if (limit > 0) {
+			sqlBuilder.append(" ").append(buildLimitSQL());
+		}
 
-        return new PreparedQueryActionImpl(getManager(), sqlBuilder.toString())
-                .setParams(hasConditionParams() ? getConditionParams() : null);
-    }
 
-    @Override
-    public @NotNull String getTableName() {
-        return tableName;
-    }
+		return new PreparedQueryActionImpl(getManager(), sqlBuilder.toString())
+				.setParams(hasConditionParams() ? getConditionParams() : null);
+	}
 
-    @Override
-    public TableQueryBuilderImpl selectColumns(@NotNull String... columnNames) {
-        this.columns = columnNames;
-        return this;
-    }
+	@Override
+	public @NotNull String getTableName() {
+		return tableName;
+	}
 
-    @Override
-    public TableQueryBuilder orderBy(@NotNull String columnName, boolean asc) {
-        this.orderBy = "ORDER BY `" + columnName + "` " + (asc ? "ASC" : "DESC");
-        return this;
-    }
+	@Override
+	public TableQueryBuilderImpl selectColumns(@NotNull String... columnNames) {
+		this.columns = columnNames;
+		return this;
+	}
 
-    @Override
-    public TableQueryBuilder setPageLimit(int start, int end) {
-        this.pageLimit = new int[]{start, end};
-        return this;
-    }
+	@Override
+	public TableQueryBuilder orderBy(@NotNull String columnName, boolean asc) {
+		this.orderBy = "ORDER BY `" + columnName + "` " + (asc ? "ASC" : "DESC");
+		return this;
+	}
 
-    @Override
-    protected TableQueryBuilderImpl getThis() {
-        return this;
-    }
+	@Override
+	public TableQueryBuilder setPageLimit(int start, int end) {
+		this.pageLimit = new int[]{start, end};
+		return this;
+	}
+
+	@Override
+	protected TableQueryBuilderImpl getThis() {
+		return this;
+	}
 }