mirror/Slimefun4
mirror/Slimefun4
1
Fork 0
mirror of https://github.com/StarWishsama/Slimefun4.git synced 2024-09-21 04:05:48 +00:00
Code Releases Activity
65af683a8a
Slimefun4/src/me/mrCookieSlime/Slimefun/api/Soul.java

40 lines
1.1 KiB
Java
Raw Normal View History

Slimefun 4
2016-04-14 16:24:03 +00:00
package me.mrCookieSlime.Slimefun.api;
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import me.mrCookieSlime.Slimefun.Variables;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
Deprecations
2019-08-25 20:01:22 +00:00
@Deprecated
Slimefun 4
2016-04-14 16:24:03 +00:00
public class Soul {
public static void storeItem(UUID uuid, ItemStack drop) {
Minor Code Optimizations
2019-06-20 08:12:34 +00:00
List<ItemStack> items = new ArrayList<>();
Slimefun 4
2016-04-14 16:24:03 +00:00
if (Variables.soulbound.containsKey(uuid)) items = Variables.soulbound.get(uuid);
items.add(drop);
Variables.soulbound.put(uuid, items);
}
public static void retrieveItems(Player p) {
if (Variables.soulbound.containsKey(p.getUniqueId())) {
for (ItemStack item: Variables.soulbound.get(p.getUniqueId())) {
Switched to "continue" as stated. Although... pondering as to why this would have seemed to have worked anyway... the way I did it, in the case of a match, the whole thing quits... which is actually fine if the user just died in a keep-inventory region. If there was a better way of determining the existence of a keep-inventory region from all plugins that might produce one, really, that's what we'd rather be checking for here anyway. This is a fine alternative, but actually identical items will result in only one being kept when dying in a non-keep-inventory situation.
2018-04-22 14:25:44 +00:00
if (item.equals(p.getInventory().getHelmet())) continue;
if (item.equals(p.getInventory().getChestplate())) continue;
if (item.equals(p.getInventory().getLeggings())) continue;
if (item.equals(p.getInventory().getBoots())) continue;
if (item.equals(p.getInventory().getItemInOffHand())) continue;
I could not use "breaK" as advised as that would completely break the loop and cease checking for duplicates among the remaining items. However, we are only checking against 5 additional slots here, so I've stated them each and made them return if a match is a bit better than setting a variable and all that, this is also more clear about what is going on here. I will state that the previous patch does introduce a limitation: identical soulbound items would be lost. Having exactly duplicated soulbound items prior to a death is a rather extreme situation, but during my testing I actually was using some I duplicated in creative mode and noticed that I would only retrieve one of each, and not the copies. It might be desireable to integrate an option here to only use this logic IF keep inventory regions will be in use somewhere, although not entirely necessary.
2018-04-20 21:53:36 +00:00
Fixed incompatibility with KeepInventory
2018-03-03 15:47:54 +00:00
if(!p.getInventory().contains(item)) {
p.getInventory().addItem(item);
}
Slimefun 4
2016-04-14 16:24:03 +00:00
}
Variables.soulbound.remove(p.getUniqueId());
}
}
}
Copy Permalink