TheBusyBiscuit
|
e78e749e94
|
Insanely huge Refactoring
|
2019-08-31 11:36:45 +02:00 |
|
TheBusyBiscuit
|
7e63ad9040
|
Removed a bunch of deprecated code
|
2019-08-30 12:13:45 +02:00 |
|
TheBusyBiscuit
|
fd36288efb
|
More Refactoring
|
2019-08-27 13:28:07 +02:00 |
|
TheBusyBiscuit
|
0925be3427
|
Deprecations
|
2019-08-25 22:01:22 +02:00 |
|
TheBusyBiscuit
|
2812b84ea8
|
Minor Code Optimizations
|
2019-06-20 10:12:34 +02:00 |
|
Rick
|
fda8f56f8a
|
Switched to "continue" as stated. Although... pondering as to why this would have seemed to have worked anyway... the way I did it, in the case of a match, the whole thing quits... which is actually fine if the user just died in a keep-inventory region. If there was a better way of determining the existence of a keep-inventory region from all plugins that might produce one, really, that's what we'd rather be checking for here anyway. This is a fine alternative, but actually identical items will result in only one being kept when dying in a non-keep-inventory situation.
|
2018-04-22 10:25:44 -04:00 |
|
Rick
|
785cbea08f
|
I could not use "breaK" as advised as that would completely break the loop and cease checking for duplicates among the remaining items. However, we are only checking against 5 additional slots here, so I've stated them each and made them return if a match is a bit better than setting a variable and all that, this is also more clear about what is going on here. I will state that the previous patch does introduce a limitation: identical soulbound items would be lost. Having exactly duplicated soulbound items prior to a death is a rather extreme situation, but during my testing I actually was using some I duplicated in creative mode and noticed that I would only retrieve one of each, and not the copies. It might be desireable to integrate an option here to only use this logic IF keep inventory regions will be in use somewhere, although not entirely necessary.
|
2018-04-20 17:53:36 -04:00 |
|
AtomicScience
|
fb07f1bb32
|
Fixed incompatibility with KeepInventory
|
2018-03-03 18:47:54 +03:00 |
|
mrCookieSlime
|
686004304c
|
Slimefun 4
|
2016-04-14 18:24:03 +02:00 |
|